-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] develop from medusajs:develop #4
Conversation
…ptions (#10622) **What** - add a list point for fetching fulfillment options for a provider - add FO support on SO create & update on dashboard - pass `cart` and `stockLocation` to `validateFufillmentData` context --- CLOSES CMRC-789 CLOSES CMRC-790
* feat: Custom line items * fix tests * fix migration * Allow custom items in update line item workflow * throw if line item doesn't have a price * minor things * wip * fix flows * fix test * add default * add to type
Reviewer's Guide by SourceryThis pull request implements support for custom line items in the cart and order workflows, along with improvements to fulfillment provider options handling. The changes include modifications to handle custom prices, tax inclusivity, and validation of line item prices across various cart operations. Updated class diagram for CartLineItemDTOclassDiagram
class CartLineItemDTO {
is_tax_inclusive: boolean
is_custom_price: boolean
calculated_price: CalculatedPrice
}
class CalculatedPrice {
// Attributes related to calculated price
}
Updated class diagram for FulfillmentProviderclassDiagram
class FulfillmentProvider {
+list(query, headers)
+listFulfillmentOptions(id, headers)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Add support for custom line items in the cart module, allowing items with custom prices and metadata. Enhance the shipping options form to include fulfillment provider options. Refactor workflows to improve line item handling and validation. Introduce functionality to retrieve fulfillment options for fulfillment providers. Update tests and documentation to cover new features and changes.
New Features:
Enhancements:
Documentation:
Tests: