Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] develop from medusajs:develop #4

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 18, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Add support for custom line items in the cart module, allowing items with custom prices and metadata. Enhance the shipping options form to include fulfillment provider options. Refactor workflows to improve line item handling and validation. Introduce functionality to retrieve fulfillment options for fulfillment providers. Update tests and documentation to cover new features and changes.

New Features:

  • Introduce support for custom line items in carts, allowing items with custom prices and metadata to be added and managed.
  • Add functionality to retrieve fulfillment options for a given fulfillment provider, enhancing the flexibility of shipping configurations.

Enhancements:

  • Refactor workflows to improve handling of line items, including validation of line item prices and updates to cart workflows.
  • Enhance the CreateShippingOptionDetailsForm component to include fulfillment provider options and selected provider ID, improving the user interface for shipping option creation.

Documentation:

  • Update documentation to reflect the new support for custom line items and the retrieval of fulfillment options.

Tests:

  • Add comprehensive tests for new cart workflows, including scenarios for adding, updating, and completing carts with custom items and price lists.

olivermrbl and others added 5 commits December 18, 2024 10:09
…ptions (#10622)

**What**
- add a list point for fetching fulfillment options for a provider
- add FO support on SO create & update on dashboard
- pass `cart` and `stockLocation` to `validateFufillmentData` context

---

CLOSES CMRC-789
CLOSES CMRC-790
* feat: Custom line items

* fix tests

* fix migration

* Allow custom items in update line item workflow

* throw if line item doesn't have a price

* minor things

* wip

* fix flows

* fix test

* add default

* add to type
@pull pull bot added the ⤵️ pull label Dec 18, 2024
Copy link

sourcery-ai bot commented Dec 18, 2024

Reviewer's Guide by Sourcery

This pull request implements support for custom line items in the cart and order workflows, along with improvements to fulfillment provider options handling. The changes include modifications to handle custom prices, tax inclusivity, and validation of line item prices across various cart operations.

Updated class diagram for CartLineItemDTO

classDiagram
    class CartLineItemDTO {
        is_tax_inclusive: boolean
        is_custom_price: boolean
        calculated_price: CalculatedPrice
    }

    class CalculatedPrice {
        // Attributes related to calculated price
    }
Loading

Updated class diagram for FulfillmentProvider

classDiagram
    class FulfillmentProvider {
        +list(query, headers)
        +listFulfillmentOptions(id, headers)
    }
Loading

File-Level Changes

Change Details Files
Added support for custom line items in cart and order workflows
  • Added is_custom_price flag to line items
  • Modified line item preparation logic to handle custom prices
  • Updated cart workflows to support custom line items
  • Added validation for line item prices
  • Added handling for custom line item removal when region changes
packages/core/core-flows/src/cart/utils/prepare-line-item-data.ts
packages/core/core-flows/src/cart/workflows/add-to-cart.ts
packages/core/core-flows/src/cart/workflows/update-cart.ts
packages/modules/cart/src/models/line-item.ts
Enhanced fulfillment provider options handling
  • Added new endpoint for retrieving fulfillment provider options
  • Added fulfillment option selection in shipping option creation
  • Updated shipping option creation form to include fulfillment options
  • Added type definitions for fulfillment provider options
packages/admin/dashboard/src/routes/locations/location-service-zone-shipping-option-create/components/create-shipping-options-form/create-shipping-option-details-form.tsx
packages/core/js-sdk/src/admin/fulfillment-provider.ts
packages/medusa/src/api/admin/fulfillment-providers/[id]/options/route.ts
Improved cart and order workflow validation
  • Added new step for validating line item prices
  • Updated variant price validation logic
  • Modified shipping method data validation
  • Added validation for custom price updates
packages/core/core-flows/src/cart/steps/validate-line-item-prices.ts
packages/core/core-flows/src/cart/steps/validate-variant-prices.ts
packages/core/core-flows/src/cart/steps/validate-shipping-methods-data.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@pull pull bot merged commit 9133957 into Stars1233:develop Dec 18, 2024
Copy link

coderabbitai bot commented Dec 18, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants